JR SC variable rename #159
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev to main June 2023
…hinx-to-main Fix: Change docs build ref to `main`
- Merging `dev` to `main`, thank you @Andrew-Clappison - Adds type checking, courtesy of @kevinkadak
changed sc_m_b -> sc_p_i sc_m_f -> sc_p_e sc_fitted -> sc_p_p
changing connection gains w_bb -> w_pi w_b -> w_i w_n_b ->w_n_pi w_ff -> w_pe w_f -> w_e w_n_f ->w_n_pe w_ll -> w_pp w_l -> w_p w_n_l->w_n_pp
sc_fitted plotting -> sc_pp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed names based on proposal in issue but how do we deal with the use of
sc_fittedin whobpyt/run/modelfitting.py -line 242 def train since thats for all models not just JR?In whobpyt/models/JansenRit/jansen_rit.py
changed fitted sc vars:
sc_m_b->sc_p_isc_m_f->sc_p_esc_fitted->sc_p_pchange connection gain variables:
w_bb->w_piw_b->w_iw_n_b->w_n_piw_ff->w_pew_f->w_ew_n_f->w_n_pew_ll->w_ppw_l->w_pw_n_l->w_n_pp