Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Update laravel/framework 11.38.2 → 11.39.0 (minor) #179

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 22, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ laravel/framework (11.38.2 → 11.39.0) · Repo · Changelog

Release Notes

11.39.0

  • [11.x] Replace duplicate ValidatedInput functions with InteractsWithData trait by @stevebauman in #54208
  • [11.x] Improve Email validation rule custom translation messages by @SanderMuller in #54202
  • [11.x] Fix deprecation warnings in optimize:clear and optimize by @cosmastech in #54197
  • [11.x] Add support for phpredis backoff and max retry config options by @TheLevti in #54191
  • Introduces UseFactory attribute by @christopherarter in #54065
  • [11.x] Set class-string generic on UseFactory by @cosmastech in #54215
  • [11.x] switch LazyCollection::make() for new LazyCollection() by @AhmedAlaa4611 in #54216
  • support style file name hashes with query strings in manifest by @newapx in #54219
  • [11.x] Solidify Rule::email() tests by @SanderMuller in #54226
  • [11.x] Fix line-ending mismatch in CliDumperTest::testArray and CliDumperTest::testObject by @AhmedAlaa4611 in #54222
  • Add a report/log option to filesystem exceptions without throwing by @lotharthesavior in #54212
  • [11.x] Fix Cache component to be aware of phpredis serialization and compression settings by @TheLevti in #54221
  • [11.x] fix: Forcing DB Session driver to always use the write connection by @mathiasgrimm in #54231
  • [11.x] Fix line-ending mismatch in BladeComponentTagCompilerTest under Illuminate\Tests\View\Blade by @AhmedAlaa4611 in #54233
  • [11.x] Fix job not logged in failed_jobs table if timeout occurs within database transaction by @decaylala in #54173
  • [11.x] Fix unique job lock is not released on model not found exception, lock gets stuck. by @zackAJ in #54000
  • [11.x] Fix line-ending mismatch on Windows test by @AhmedAlaa4611 in #54236
  • Added support in DB::prohibitDestructiveCommands to preventing destructive Rollback… by @hexathos in #54238
  • [11.x] Add applyAfterQueryCallbacks Support to Non-Mutator Cases in pluck Method by @batinmustu in #54268
  • [11.x] addPath() Allow adding new path for translation loader. by @selcukcukur in #54277

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 26 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Summary by Sourcery

Update laravel/framework from 11.38.2 to 11.39.0.

Bug Fixes:

  • Fix deprecation warnings in optimize:clear and optimize.
  • Fix job not logged in failed_jobs table if timeout occurs within database transaction.
  • Fix unique job lock not released on model not found exception.
  • Force DB Session driver to always use the write connection.

Enhancements:

  • Replace duplicate ValidatedInput functions with InteractsWithData trait.
  • Improve Email validation rule custom translation messages.
  • Add support for phpredis backoff and max retry config options.
  • Introduce UseFactory attribute.
  • Switch LazyCollection::make() for new LazyCollection().
  • Support style file name hashes with query strings in manifest.
  • Solidify Rule::email() tests.
  • Add a report/log option to filesystem exceptions without throwing.
  • Fix Cache component to be aware of phpredis serialization and compression settings.
  • Add applyAfterQueryCallbacks Support to Non-Mutator Cases in pluck Method.
  • addPath() Allow adding new path for translation loader.
  • Added support in DB::prohibitDestructiveCommands to preventing destructive Rollback.

@depfu depfu bot added the depfu label Jan 22, 2025
Copy link

korbit-ai bot commented Jan 22, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

Review changes with  SemanticDiff

Copy link

pr-code-reviewer bot commented Jan 22, 2025

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request updates the laravel/framework dependency from version 11.38.2 to 11.39.0. This is a minor version update that includes several bug fixes and new features.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the laravel/framework dependency.
  • Updated laravel/framework from 11.38.2 to 11.39.0 in composer.lock.
composer.lock
Introduced the UseFactory attribute.
  • Added the UseFactory attribute to the framework.
  • Updated HasFactory trait to use the UseFactory attribute.
  • Updated HasRelationships trait to use the UseFactory attribute.
  • Updated Model class to use the UseFactory attribute.
vendor/laravel/framework/src/Illuminate/Database/Eloquent/Factories/HasFactory.php
vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasRelationships.php
vendor/laravel/framework/src/Illuminate/Database/Eloquent/Factories/UseFactory.php
vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php
Replaced duplicate ValidatedInput functions with InteractsWithData trait.
  • Removed duplicate ValidatedInput functions.
  • Added InteractsWithData trait to share the ValidatedInput functionality.
vendor/laravel/framework/src/Illuminate/Foundation/Validation/ValidatesRequests.php
vendor/laravel/framework/src/Illuminate/Support/InteractsWithData.php
Improved Email validation rule custom translation messages.
  • Updated the Email validation rule to provide more specific custom translation messages.
vendor/laravel/framework/src/Illuminate/Validation/Rules/Email.php
Fixed deprecation warnings in optimize:clear and optimize commands.
  • Resolved deprecation warnings in the optimize:clear command.
  • Resolved deprecation warnings in the optimize command.
vendor/laravel/framework/src/Illuminate/Foundation/Console/OptimizeClearCommand.php
vendor/laravel/framework/src/Illuminate/Foundation/Console/OptimizeCommand.php
Added support for phpredis backoff and max retry config options.
  • Added configuration options for phpredis backoff and max retry.
vendor/laravel/framework/src/Illuminate/Redis/Connectors/PhpRedisConnector.php
Switched LazyCollection::make() for new LazyCollection().
  • Replaced LazyCollection::make() with new LazyCollection() for instantiation.
vendor/laravel/framework/src/Illuminate/Support/LazyCollection.php
Added support for style file name hashes with query strings in manifest.
  • Updated Mix class to support style file name hashes with query strings in manifest.
vendor/laravel/framework/src/Illuminate/Foundation/Mix.php
Solidified Rule::email() tests.
  • Improved the tests for the Rule::email() method.
vendor/laravel/framework/tests/Validation/RuleEmailTest.php
Fixed line-ending mismatches in CliDumperTest.
  • Corrected line-ending mismatches in CliDumperTest::testArray.
  • Corrected line-ending mismatches in CliDumperTest::testObject.
vendor/laravel/framework/tests/Support/CliDumperTest.php
Added a report/log option to filesystem exceptions without throwing.
  • Added functionality to report or log filesystem exceptions without throwing them.
vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php
Fixed Cache component to be aware of phpredis serialization and compression settings.
  • Updated the Cache component to handle phpredis serialization and compression settings.
vendor/laravel/framework/src/Illuminate/Cache/RedisStore.php
Forced DB Session driver to always use the write connection.
  • Modified the DB Session driver to consistently use the write connection.
vendor/laravel/framework/src/Illuminate/Session/DatabaseSessionHandler.php
Fixed line-ending mismatch in BladeComponentTagCompilerTest.
  • Corrected line-ending mismatches in BladeComponentTagCompilerTest.
vendor/laravel/framework/tests/View/Blade/BladeComponentTagCompilerTest.php
Fixed job not logged in failed_jobs table if timeout occurs within database transaction.
  • Ensured jobs are logged in the failed_jobs table even if a timeout occurs within a database transaction.
vendor/laravel/framework/src/Illuminate/Queue/Worker.php
Fixed unique job lock not released on model not found exception.
  • Ensured unique job locks are released when a model not found exception occurs.
vendor/laravel/framework/src/Illuminate/Queue/InteractsWithQueue.php
Fixed line-ending mismatch on Windows test.
  • Corrected line-ending mismatches in PresetCommandTest on Windows.
vendor/laravel/framework/tests/Foundation/Console/PresetCommandTest.php
Added support in DB::prohibitDestructiveCommands to prevent destructive Rollback.
  • Added functionality to prevent destructive Rollback commands using DB::prohibitDestructiveCommands.
vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php
vendor/laravel/framework/src/Illuminate/Database/Connection.php
Added applyAfterQueryCallbacks support to non-mutator cases in pluck method.
  • Added support for applyAfterQueryCallbacks in non-mutator cases within the pluck method.
vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php
Allowed adding new path for translation loader.
  • Added the ability to add new paths for the translation loader.
vendor/laravel/framework/src/Illuminate/Translation/FileLoader.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@guibranco guibranco enabled auto-merge (squash) January 22, 2025 16:46
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Jan 22, 2025
Copy link

coderabbitai bot commented Jan 22, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gooroo-dev bot commented Jan 22, 2025

Please double check the following review of the pull request:

Since the provided diff is empty, there are no changes to review. However, I will follow the guidelines and provide a structured response based on the absence of changes.

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

Since there are no changes in the diff, there are no items to list under "Changes in the diff."

Identified Issues

As there are no changes, there are no identified issues to report.

Explanation of Identified Issues

There are no issues to explain due to the lack of changes in the diff.

Missing Tests

Since there are no changes, no new tests are needed. However, if this update is related to a version upgrade, it is advisable to run existing tests to ensure compatibility with the new version.

Summon me to re-review when updated! Yours, Gooroo.dev
React or reply to let me know what you think!

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. Version Update Risk:

    • composer.lock (Lines 1-3): The version of laravel/framework is updated from v11.38.2 to v11.39.0. Without testing this version in your application, you may introduce breaking changes if there are any that affect your existing code base. It's crucial to review release notes for breaking changes associated with this update.
  2. Reference Update:

    • composer.lock (Lines 1-3): The reference for the framework has also changed. Ensure that the new reference (996c9695f78e8a2b26a24c490a1721cfb14574f) corresponds to a stable release. Using an unstable commit may lead to unpredictable behavior in your application.
  3. Time Field Update:

    • composer.lock (Lines 4-6): The time field was modified to a future date (2025-01-21T15:02:43+00:00). This could mislead developers regarding the availability or support status of the framework. Ensure this value reflects the accurate release or a compliant date in your project's context.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. Test After Updating:

    • composer.lock (All lines): After updating laravel/framework, ensure you conduct thorough testing (unit tests, integration tests, etc.) to confirm that existing features remain intact and to reveal any potential issues from the version change.
  2. Documentation Review:

    • composer.lock (Lines 1-3): Document the intent and rationale for the framework upgrade in your project’s changelog or documentation. This can help other developers understand why the change was made and track project dependencies over time.
  3. Monitor Dependency Changes:

    • composer.lock (All lines): Implement a monitoring or alerting system for dependency updates. Tools like Dependabot can provide notifications when there are new releases, ensuring that you're aware of important updates that may include critical patches or features.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, depfu[bot]!). We assume it knows what it's doing!

Copy link

instapr bot commented Jan 22, 2025

Feedback:

  • Version updated to 11.39.0.
  • Test results and changes reviewed.
  • Ready for merge.

Keep up the good work! 👍🏼

Copy link

deepsource-io bot commented Jan 22, 2025

Here's the code health analysis summary for commits 85dc032..e434ed4. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource SQL LogoSQL✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource PHP LogoPHP✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePhp
Branch Coverage100%100%
Composite Coverage33.3%33.3%
Line Coverage33.3%33.3%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Jan 22, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2025
@guibranco
Copy link
Member

@depfu merge

Copy link

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
4:47PM INF scanning for exposed secrets...
4:47PM INF 178 commits scanned.
4:47PM INF scan completed in 402ms
4:47PM INF no leaks found

@guibranco guibranco merged commit d96a4fd into main Jan 22, 2025
24 of 25 checks passed
@guibranco guibranco deleted the depfu/update/composer/laravel/framework-11.39.0 branch January 22, 2025 16:47
Copy link

korbit-ai bot commented Jan 22, 2025

I was unable to write a description for this pull request. This could be because I only found files I can't scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations depfu size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants