Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Testcontainers from 3.10.0 to 4.0.0 #250

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps Testcontainers from 3.10.0 to 4.0.0.

Release notes

Sourced from Testcontainers's releases.

4.0.0

What's Changed

Thanks so much for all the effort you put into this release 🙌. We are continuing to align Testcontainers for .NET with other language implementations and working on improving the domain-specific language.

We have updated the IImage interface to follow the domain-specific language with the correct property names. The table below shows the changes. We tried to make the transition as smooth as possible, but be aware that relying on the Repository property might cause issues since it now resolves a different value than before. We have kept the old properties, marked them as obsolete, and provided guidance on how to migrate.

Actual Expected (New)
Registry - myregistryhost:5000
Repository myregistryhost:5000/fedora fedora/httpd
Name httpd -
Tag version1.0 version1.0
Digest - sha256:37a3b014d320...
GetHostname() myregistryhost:5000 myregistryhost:5000

⚠️ Breaking Changes

🚀 Features

🐛 Bug Fixes

  • fix: Bump MSSQL image version, remove Azure SQL Edge and Papercut module (#1265) @​HofmeisterAn
  • fix: Throw exception if Docker resource does not exist instead of silently ignoring it (#1254) @​0xced

🧹 Housekeeping

Commits
  • 1a78654 fix: XML comment has cref attribute 'FullName' that could not be resolved
  • dfb9f41 feat: Use exec to replace current shell with the Kafka process (as ENTRYPOI...
  • a75cb73 feat: Add getter for Azurite blob, queue and table endpoint (#1278)
  • 12cccf9 chore: Bump System.Text.Json
  • 159e4bf feat: Reintroduce Papercut module (#1268)
  • f4966d8 fix: Remove Sonar code smells
  • e96d4e6 feat: Add Neo4j Enterprise Edition support (WithEnterpriseEdition(bool)) (#...
  • 0b8b34b chore: Run test projects sequentially
  • 1cc56ea fix: Use correct JSON node to install C# Dev Kit extension
  • 340a93a fix: Do not run reusable resource tests in parallel (#1267)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Upgrade Testcontainers to version 4.0.0, introducing breaking changes and new features such as Neo4j Enterprise Edition support, and aligning IImage properties with Docker DSL. Fix issues related to Docker resource handling and improve overall consistency.

New Features:

  • Introduce support for Neo4j Enterprise Edition with a new configuration option.

Bug Fixes:

  • Fix issue where Docker resources that do not exist now throw an exception instead of being silently ignored.

Enhancements:

  • Align IImage properties with Docker DSL for improved consistency across language implementations.

Chores:

  • Bump Testcontainers from version 3.10.0 to 4.0.0.

Bumps [Testcontainers](https://github.com/testcontainers/testcontainers-dotnet) from 3.10.0 to 4.0.0.
- [Release notes](https://github.com/testcontainers/testcontainers-dotnet/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-dotnet/blob/develop/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-dotnet@3.10.0...4.0.0)

---
updated-dependencies:
- dependency-name: Testcontainers
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Nov 4, 2024
@dependabot dependabot bot requested a review from guibranco November 4, 2024 17:59
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 4, 2024

The following labels could not be found: nuget, packages.

Copy link

korbit-ai bot commented Nov 4, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

Review changes with  SemanticDiff

Copy link

sourcery-ai bot commented Nov 4, 2024

Reviewer's Guide by Sourcery

This PR updates the Testcontainers package from version 3.10.0 to 4.0.0, which introduces breaking changes in the IImage interface properties to better align with Docker DSL, along with several new features and bug fixes.

Updated class diagram for IImage interface

classDiagram
    class IImage {
        <<interface>>
        - string Registry
        - string Repository
        - string Name
        - string Tag
        - string Digest
        - string GetHostname()
    }
    note for IImage "Properties have been updated to align with Docker DSL."

    class DockerImage {
        - string Registry
        - string Repository
        - string Name
        - string Tag
        - string Digest
        - string GetHostname()
    }
    IImage <|-- DockerImage
    note for DockerImage "DockerImage now supports digest."
Loading

File-Level Changes

Change Details Files
Major version upgrade of Testcontainers with breaking changes to IImage interface
  • Registry, Repository, Name, Tag, and Digest properties have been realigned to match Docker DSL
  • Repository property now resolves to a different value than before
  • Old properties are marked as obsolete with migration guidance
Tests/SolutionName.IntegrationTests/SolutionName.IntegrationTests.csproj
New features and improvements in Testcontainers functionality
  • Added support for Neo4j Enterprise Edition
  • Added support for digest in IImage and DockerImage
  • Added getters for Azurite blob, queue and table endpoints
  • Improved Kafka process handling using exec
  • Added Docker endpoint retrieval from Docker context
Tests/SolutionName.IntegrationTests/SolutionName.IntegrationTests.csproj
Bug fixes and improvements in error handling
  • Added exception throwing for non-existent Docker resources
  • Updated MSSQL image version
  • Fixed parallel test execution issues for reusable resources
Tests/SolutionName.IntegrationTests/SolutionName.IntegrationTests.csproj

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

pr-code-reviewer bot commented Nov 4, 2024

👋 Hi there!

  1. Make sure that the updated version of "Testcontainers" (4.0.0) is compatible with other dependencies.
  2. Consider checking for any breaking changes or new features in Testcontainers 4.0.0 that might impact existing code.
  3. Ensure that the project builds and runs successfully after updating the Testcontainers version.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior.

  1. /Tests/SolutionName.IntegrationTests/SolutionName.IntegrationTests.csproj - Upgrading from Testcontainers version 3.10.0 to 4.0.0 may introduce breaking changes. Ensure to review the changelog and migration guide for Testcontainers to identify any required code adjustments and validate that the existing integration tests function as expected with the new version.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency.

  1. /Tests/SolutionName.IntegrationTests/SolutionName.IntegrationTests.csproj - Consider specifying and locking the version of Microsoft.NET.Test.Sdk, Moq, and WireMock.Net to known compatible versions if applicable. This prevents unexpected behavior or incompatibility in future runs due to automatic package updates.

Copy link

coderabbitai bot commented Nov 4, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gooroo-dev bot commented Nov 4, 2024

Please double check the following review of the pull request:

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

  • 🛠️ No changes were detected in the diff.

Identified Issues

Since there are no changes in the diff, there are no identified issues to report.

Missing Tests

Since there are no changes in the diff, there are no missing tests to generate.

Summon me to re-review when updated! Yours, Gooroo.dev
React or reply to share your opinion with me!

@guibranco guibranco enabled auto-merge (squash) November 4, 2024 17:59
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

Copy link

instapr bot commented Nov 4, 2024

Feedback on PR

  • Testcontainers has been successfully bumped from 3.10.0 to 4.0.0.
  • Review the Release notes and Commits for details on changes.
  • The SolutionName.IntegrationTests.csproj file has been updated to reference Testcontainers 4.0.0.

Overall, the PR looks good. Thank you for the update! 👍

@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Nov 4, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Nov 4, 2024
@guibranco
Copy link
Member

@dependabot squash and merge

Copy link

github-actions bot commented Nov 4, 2024

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
6:01PM INF scanning for exposed secrets...
6:01PM INF 339 commits scanned.
6:01PM INF scan completed in 97.9ms
6:01PM INF no leaks found

Copy link

codeclimate bot commented Nov 4, 2024

Code Climate has analyzed commit be17017 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 4, 2024

@guibranco
Copy link
Member

@gstraccini codacy bypass

Copy link
Contributor

gstraccini bot commented Nov 4, 2024

Bypassing the Codacy analysis for this pull request! ⚠️

@guibranco guibranco merged commit a230ec5 into main Nov 4, 2024
25 checks passed
@guibranco guibranco deleted the dependabot/nuget/Testcontainers-4.0.0 branch November 4, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations dependencies Pull requests that update a dependency file .NET Pull requests that update .net code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

1 participant