-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #207
Documentation #207
Conversation
I just realized that it might make sense to include the |
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 77.61% 80.91% +3.30%
==========================================
Files 7 7
Lines 411 414 +3
Branches 89 97 +8
==========================================
+ Hits 319 335 +16
+ Misses 64 51 -13
Partials 28 28
|
Hi @alexvoss Firstly thanks for your interest and taking time to make some PRs!
They do. Can you just remove changes to util.py please to make this PR focused on documentation?
And please, feel free to propose theses changes too. In this same PR if you want this time 😉. |
Ok, will do. I will scrap this PR as I have no idea how to rewrite Git history. I think I am too old for that. |
Hello @alexvoss, Since you're too old for cherry-picking or somewhat, I've use your small documentation improvements in my documentation refacto https://guts.github.io/mkdocs-rss-plugin/ and also in the readme. YAMBWUM1! Can you check it if I've missed something and close here if everything is right? Footnotes
|
@alexvoss I'm closing here. |
A couple of small changes to the documentation. Hope they make sense.
I would suggest more if you agree that they would be useful:
venv
to create a virtual environmentPIP_REQUIRE_VIRTUALENV
variable so they don't install everything into a global environmentpytest --no-cov
option when debugging. I can do this for VSCode.Edit: could look a bit like https://squidfunk.github.io/mkdocs-material/customization/#environment-setup