Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on locale configuration #256

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

YDX-2147483647
Copy link
Contributor

locale at root was deprecated in #212, and theme/language only works for Material theme.

Relevant implementation:

if (
self.social_cards.IS_THEME_MATERIAL
and "language" in mkdocs_config.theme
):

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 5, 2024
`locale` at root was deprecated in Guts#212, and `theme/language` only works for Material theme.

Relevant implementation:

https://github.com/Guts/mkdocs-rss-plugin/blob/15938261138769919c714e60d4925c58bffa81e1/mkdocs_rss_plugin/util.py#L720-L723

Signed-off-by: Y.D.X. <73375426+YDX-2147483647@users.noreply.github.com>
@YDX-2147483647 YDX-2147483647 marked this pull request as ready for review March 5, 2024 15:25
@Guts Guts merged commit 6226559 into Guts:main Mar 5, 2024
2 checks passed
@Guts
Copy link
Owner

Guts commented Mar 5, 2024

Thanks!

@YDX-2147483647 YDX-2147483647 deleted the patch-1 branch March 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants