Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check default_time before parsing #291

Closed
wants to merge 2 commits into from
Closed

Conversation

ZhiyuanChen
Copy link

fix #290

ZhiyuanChen and others added 2 commits June 11, 2024 21:21
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.79%. Comparing base (7e51e12) to head (d2e5606).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   83.94%   83.79%   -0.16%     
==========================================
  Files           9        9              
  Lines         542      543       +1     
  Branches      114      115       +1     
==========================================
  Hits          455      455              
  Misses         56       56              
- Partials       31       32       +1     
Flag Coverage Δ
unittests 83.79% <66.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mkdocs_rss_plugin/plugin.py 90.00% <66.66%> (-0.70%) ⬇️

@Guts
Copy link
Owner

Guts commented Jun 11, 2024

Thanks!

Please, can you add a test case in tests/fixtures corresponding to the fix?

@Guts
Copy link
Owner

Guts commented Jun 23, 2024

As exlpained here, I wont' accept your PR since the code you propose is a duplicate from the default configuration (not really suitable) and the issue come from antoher plugin.

However, I'll handle the error better in another PR so it won't be blocking.

@Guts Guts closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: strptime() argument 1 must be str, not datetime.datetime
2 participants