Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: improve social cards integration #294

Merged
merged 4 commits into from
Jun 15, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 14, 2024

Related to #257

@github-actions github-actions bot added the enhancement New feature or request label Jun 14, 2024
@Guts Guts force-pushed the feature/improve-social-cards-integration branch from eafd779 to df90ba1 Compare June 14, 2024 14:28
@Guts Guts force-pushed the feature/improve-social-cards-integration branch from df90ba1 to 6dd581e Compare June 14, 2024 14:29
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (a51c596) to head (fd0b4d8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   83.24%   80.49%   -2.76%     
==========================================
  Files           9        9              
  Lines         549      610      +61     
  Branches      116      127      +11     
==========================================
+ Hits          457      491      +34     
- Misses         60       82      +22     
- Partials       32       37       +5     
Flag Coverage Δ
unittests 80.49% <62.96%> (-2.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mkdocs_rss_plugin/util.py 73.12% <57.14%> (+0.21%) ⬆️
...lugin/integrations/theme_material_social_plugin.py 76.42% <63.51%> (-20.46%) ⬇️

Copy link

sonarqubecloud bot commented Jun 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit 06ec44d into main Jun 15, 2024
9 checks passed
@Guts Guts deleted the feature/improve-social-cards-integration branch June 15, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interaction with mkdocs-material, images produces by Social plugin cause error
1 participant