Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rss): email and name were inverted in output and so uncompliant #343

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Dec 16, 2024

Related to: #250
See: https://validator.w3.org/feed/docs/error/InvalidContact.html

Before:

<author>John Doe (John.Doe@example.com)</author>

After:

<author>John.Doe@example.com (John Doe)</author>

cc @stefansli

@github-actions github-actions bot added the bug Something isn't working label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (7569e08) to head (1752ef1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files          11       11           
  Lines         747      747           
  Branches      125      125           
=======================================
  Hits          606      606           
  Misses         97       97           
  Partials       44       44           
Flag Coverage Δ
unittests 81.12% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._plugin/integrations/theme_material_blog_plugin.py 77.35% <100.00%> (ø)

@Guts Guts merged commit 7d4b7c5 into main Dec 16, 2024
12 checks passed
@Guts Guts deleted the fix/blog-inverted-values-rss-author-email branch December 16, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant