Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config command #174

Closed
wants to merge 0 commits into from
Closed

add config command #174

wants to merge 0 commits into from

Conversation

cheny-alf
Copy link

No description provided.

@cheny-alf
Copy link
Author

@HDT3213 可以帮review下吗,顺便看看为什么pipeline 中有个测试过不了呢

@HDT3213
Copy link
Owner

HDT3213 commented May 12, 2023

=== RUN   TestConfigSet
    assert.go:146: expected $3
        128
        , actually &{[%!s(*protocol.BulkReply=&{[109 97 120 99 108 105 101 110 116 115]}) %!s(*protocol.BulkReply=&{[48]})]}, at /home/runner/work/godis/godis/database/config_test.go:47
--- FAIL: TestConfigSet (0.56s)

go 里面每次 for-each map 的顺序是随机的, 所以 setConfig 每次返回的 MultiBulkReply 是不一样的

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
database/config.go Outdated Show resolved Hide resolved
database/config.go Outdated Show resolved Hide resolved
@HDT3213
Copy link
Owner

HDT3213 commented May 14, 2023

请阅读 #146

  • 请确保您的代码进行了 gofmt,并通过了 golint 的检测。
  • 请保持 git 时间线的整洁。一个 PR 中应只包含一个或数个 commit,请在提 PR 前 squash 掉开发过程中产生的、不需要保留的 commit

config/config.go Outdated Show resolved Hide resolved
database/config.go Outdated Show resolved Hide resolved
database/config.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants