Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login fail if duplicate token request #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

filipcekic
Copy link

in some cases, when user tries to login, duplicate token request is made. with the current pop() method, first request will verify token and delete it, and then when other (duplicate) token request arrives - token is not existing (deleted by first request) and therefore login will fail.

Changes were done to pop() method:

  • do not remove token upon verification (stays in db)
  • remove expired tokens before verification (this is just to clean expired tokens from db)

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants