Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROD] Fix seeding; sort by date not string; add code coverage; soft delete duplicate and orphaned objectives #2584

Merged
merged 207 commits into from
Jan 10, 2025
Merged

[PROD] Fix seeding; sort by date not string; add code coverage; soft delete duplicate and orphaned objectives #2584

merged 207 commits into from
Jan 10, 2025

Conversation

kryswisnaskas
Copy link
Collaborator

@kryswisnaskas kryswisnaskas commented Jan 7, 2025 •
edited
Loading

Description of change

  • Fixed seeding user account data for the non-prod environments.
  • Add code coverage
  • Sort by Date not String
  • Soft delete duplicate and orphaned Objectives.
  • removed used of tee to support MacOS

How to test

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • [n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions
  • [n/a] UI review complete
  • [n/a] QA review complete

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@GarrettEHill
restore lost changes
5b59e92
@GarrettEHill
add 15 min interval checking
7c5acc9
@GarrettEHill
add support to turn off similarity api too
1309adc
@GarrettEHill
for testing add current branch for triggering as well
5f20fb4
@GarrettEHill
Update config.yml
71cfedf
@GarrettEHill
Update config.yml
00b950d
@GarrettEHill
add locking system to prevent collisions of interacting with environm…
a72ecf4 
…ents
@GarrettEHill
fix name use
2294fe7
@GarrettEHill
make executable
c5fd264
@GarrettEHill
Update config.yml
b13826b
@GarrettEHill
some updates
0bfbe93
@GarrettEHill
switch out user token
c097fe5
@GarrettEHill
typo
4f4143f
@GarrettEHill
move to script file
bd2fc71
@GarrettEHill
Update release-lock.sh
9c4accd
@GarrettEHill
Update config.yml
b7b53ef
@GarrettEHill
debug
3c303a4
@GarrettEHill
Update manage_apps.sh
c2dc15e
@GarrettEHill
Update manage_apps.sh
a95692f
@GarrettEHill
debug
f9cb258
@GarrettEHill
restructure
0805124
@GarrettEHill
adjust window to be 60 min, also consider system power-on as an activ…
caa9f82 
…ity event
@GarrettEHill
skip if already stopped
f195847
@GarrettEHill
Update manage_apps.sh
c905658
@GarrettEHill
Update release-lock.sh
df28da1
@GarrettEHill
debug
3ca394d
@GarrettEHill
debug
d942cb6
@GarrettEHill
refactor again
98c4f1b
@GarrettEHill
debugging lock
cb3aa0e
@GarrettEHill
debug
851864a
AdamAdHocTeam and others added 25 commits January 2, 2025 16:13
@AdamAdHocTeam
add coverage
54e9b84
@AdamAdHocTeam
more test coverage
bfa5fd1
@AdamAdHocTeam
lint
412de9f
@kryswisnaskas
[ttahub-3753] Update hsesUsername for one account.
97b5e86
@AdamAdHocTeam
more test coverage
633bf8e
@AdamAdHocTeam
add another coverage test
0762477
deletedAt objectives created on ARs but not on an AR
031233e
@AdamAdHocTeam
Merge pull request #2579 from HHS/al-ttahub-3250-mailer-coverage
1ddbaa6 
[TTAHUB-3250] Increase code coverage on src\mailer\index.js
@hardwarehuman
Merge pull request #2580 from HHS/ttahub-3741/clean_up_orphan_objectives
0366646 
[TTAHUB-3741] set deletedAt for objectives created on ARs but not on an AR
@GarrettEHill
new version and tests
1cc150b
@GarrettEHill
lint
c90a1dd
@GarrettEHill
lint
66b6f83
@GarrettEHill
fix sequelize
584f5bb
@GarrettEHill
lint
2f81bb9
@GarrettEHill
clean up
b851d2a
@GarrettEHill
added association
77814fc
@GarrettEHill
unscope no longer needed
1d1cada
@kryswisnaskas
Merge pull request #2582 from HHS/kw-ttahub-3753
2b66651 
[ttahub-3753] Update hsesUsername for one account.
@GarrettEHill
Merge pull request #2581 from HHS/TTAHUB-2827/refactor-topicsByGoalSt…
4e30b82 
…atus

[TTAHUB-2827] Rafacter topicsByGoalStatus
@GarrettEHill
sort by date not string
315106d
@GarrettEHill
Update communicationLog.test.js
35851b5
@GarrettEHill
supress lint issue as its needed for correct sql formating
3f883b6
@GarrettEHill
Merge pull request #2585 from HHS/TTAHUB-3761/string-date-sort-order
e2aab35 
[TTAHUB-3761] Sort by Date not String
@GarrettEHill
macos does not like tee
006c574
@GarrettEHill
Merge pull request #2588 from HHS/TTAHUB-3750/resupport-macos
66332c3 
[TTAHUB-3750] macos does not like tee
@kryswisnaskas kryswisnaskas changed the title [PROD] Fix seeding; [PROD] Fix seeding; sort by date not string; add code coverage; soft delete duplicate and orphaned objectives Jan 9, 2025
@kryswisnaskas kryswisnaskas marked this pull request as ready for review January 9, 2025 22:18
@Jones-QuarteyDana Jones-QuarteyDana merged commit 0e60a53 into production Jan 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jones-QuarteyDana Jones-QuarteyDana Jones-QuarteyDana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kryswisnaskas @Jones-QuarteyDana @GarrettEHill @nvms @thewatermethod @AdamAdHocTeam @hardwarehuman