New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking notebook #22

Closed

avnikitin wants to merge 0 commits into HSE-LAMBDA:main from avnikitin:main

Contributor

avnikitin commented Jul 10, 2023

No description provided.

Collaborator

hushchyn-mikhail commented Jul 11, 2023

@avnikitin, hi!
Thank you for your notebook. The experiment pipeline is correct in general. And there are several comments:
-- PE_score | PE | PE_sym | Wasserstein are not quality metrics. They are obsolete and will be removed in the next version.
-- Let's try window_size=lag_size=50. It will make the task harder
-- It will be also useful to show a plot with change point detection scores
-- Add also ruptures.Window method (https://centre-borelli.github.io/ruptures-docs/user-guide/detection/window/) with 'rbf' model, please.
-- Let's also compare with https://github.com/HolyBayes/klcpd
-- And with https://github.com/daisuke-motoki/change_point_detector

avnikitin closed this

avnikitin force-pushed the main branch 2 times, most recently from e8707ab to 21e5abb Compare

July 31, 2023 22:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment