Merge pull request #178 from HSLdevcom/fix-npe

Add check for null
HSLdevcom · Sep 18, 2017 · 8e12f21 · 8e12f21
2 parents f5e0d5a + 152b5a1
commit 8e12f21
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/org/opentripplanner/index/FieldErrorInstrumentation.java b/src/main/java/org/opentripplanner/index/FieldErrorInstrumentation.java
@@ -71,7 +71,7 @@ private void setMetadata() {
         MDC.put("router", router.id);
         MDC.put("time", Long.toString(System.currentTimeMillis() - time));
         MDC.put("query", query);
-        MDC.put("arguments", variables.toString());   
+        MDC.put("arguments", variables!=null ? variables.toString() : "");   
         if(headers!=null) {
             MDC.put("userAgent", headers.getFirst(HttpHeaders.USER_AGENT));
             MDC.put("referer", headers.getFirst("referer"));
@@ -96,7 +96,9 @@ public void onEnd(ExecutionResult result) {
                 if(result.getErrors().size() > 0) {
                     StringBuilder errors = new StringBuilder();
                     for(GraphQLError e: result.getErrors()){
-                        errors.append(e.getMessage()).append("\n");
+                        if(e != null) {
+                            errors.append(e.getLocations()).append(e.getErrorType()).append(e.getMessage()).append("\n");
+                        }
                     }
                     MDC.put("errors", errors.toString());
                 }