Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most yarn resolution warnings #4751

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Feb 15, 2023

Proposed Changes

  • Fixes most yarn resolution warnings (yarn resolution warnings #4742) by
    • defining packageExtensions for external packages with missing peerDeependencies
    • defining missing peerDependencies for digitransit and it's components
    • convert some fixed package versions to version ranges, so required versions can be met
    • add resolution for html-webpack-plugin (prevents resolution of html-wepack@5 when favicon@^3 will be used)

Still todo: hsl.fi related warnings and migration of eslint-plugin-graphql (see #4750)

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@vesameskanen vesameskanen merged commit 12225e1 into HSLdevcom:v3 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants