Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-5904 (DT-5325) CO2 emissions #4881

Merged
merged 41 commits into from
Nov 22, 2023
Merged

DT-5904 (DT-5325) CO2 emissions #4881

merged 41 commits into from
Nov 22, 2023

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Nov 7, 2023

Proposed Changes

  • Show CO2 emissions
  • Configured for HSL and Matka

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

sharhio and others added 29 commits July 5, 2023 15:19
@sharhio
feat: dt-5325 co2 emissions
ddca1ce
@sharhio
Merge branch 'v3' into DT-5325
bfdc531
@sharhio
feat: dt-5325 co2 schemas
ec56632
@sharhio
feat: dt-5325 co2 schema update
8e59711
@Antiik91
chore: mobile styling, show emission info in mobile also
bc1e0c5
@Antiik91
chore: add placeholders for translations
67aa244
@Antiik91
chore: update localStorage
a22b193
@Antiik91
refactor: do not add car value when car route is not available
b3488b2
@Antiik91
refactor: remove loading as it stays forever if no data
ca5cebf
@Antiik91
feat: translations and links to emissions info
9051e97
@Antiik91
chore: edit test
6de024d
@sharhio
feat: ft-5325 simplifying css
c6929be
@sharhio
feat: dt-5325 no localstorage, no separate force car setting
cffe172
@sharhio
feat: dt-5325 documentation for co2 setting, removed from defaultsett…
18b4628 
…ings
@sharhio
feat: dt-5325 accessibility improvements
e1ed13f
@sharhio
Merge branch 'v3' into DT-5325
d522c69
@sharhio
feat: dt-5325 allow showing zero emissions
7cf37e6
@sharhio
feat: dt-5325 show 0 emissions, short description when no car iti
066feac
@sharhio
fix: dt-5325 emissions value nonzero if doesnt exist
02d6581
@sharhio
chore: dt-5325 emissions turned on in matka
5e68ad1
@sharhio
fix: dt-5325 emission zero values
b73671b
@sharhio
fix: dt-5325 lowest co2 value filterting fix
b69bab3
@sharhio
feat: dt-5325 co2 type changes
2a7dcca
@sharhio
feat: dt-5325 emissions naming changes, car value fix
878dda8
@Antiik91
refactor: fix text and adjust new text to description of co2
5c06dbf
@sharhio
feat: dt-5325 emissions schema changes
92eb64d
@sharhio
fix: otp schema location update
5cba798
@sharhio
fix: dt-5325 translations
abe684f
@sharhio
Merge branch 'v3' into DT-5325
b7e854f
@sharhio sharhio changed the title DT-5325 CO2 emissions DT-5904 (DT-5325) CO2 emissions Nov 9, 2023
optionsome
optionsome requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@optionsome optionsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, in the view with the itinerary suggestion open, the emissions on the top of the view should be moved slightly to the right. I didn't fully test yet because there were some questions about the spec and issues with testing as the otp data configuration was accidentally removed in a merge conflict.

app/component/ItineraryTab.js Outdated Show resolved Hide resolved
app/component/ItineraryTab.js Outdated Show resolved Hide resolved
app/component/ItineraryTab.js Outdated Show resolved Hide resolved
app/component/ItineraryTab.js Outdated Show resolved Hide resolved
app/component/ItineraryTab.js Outdated Show resolved Hide resolved
app/component/itinerary.scss Outdated Show resolved Hide resolved
app/configurations/config.default.js Outdated Show resolved Hide resolved
app/configurations/config.hsl.js Outdated Show resolved Hide resolved
app/configurations/config.jyvaskyla.js Outdated Show resolved Hide resolved
app/configurations/config.matka.js Outdated Show resolved Hide resolved
@sharhio sharhio requested a review from optionsome November 21, 2023 09:06
@optionsome optionsome merged commit 4467949 into v3 Nov 22, 2023
6 checks passed
@optionsome optionsome deleted the DT-5325 branch November 22, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbruch hbruch hbruch left review comments

@optionsome optionsome optionsome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharhio @hbruch @optionsome @Antiik91