Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-6166: Fix UI crashing when timetable view does not have any stoptimes #4901

Merged
merged 1 commit into from
Dec 13, 2023
Merged

DT-6166: Fix UI crashing when timetable view does not have any stoptimes #4901

merged 1 commit into from
Dec 13, 2023

Conversation

Antiik91
Copy link
Member

Proposed Changes

  • As title suggests.
  • You can test this doing a station search in front page. Type Kerava ase and select the one that has old icon in suggestions. There is no departures. And if you click timetable section, without this fix UI will crash.

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@vesameskanen vesameskanen merged commit d5e0a03 into v3 Dec 13, 2023
6 checks passed
@vesameskanen vesameskanen deleted the DT-6166 branch December 13, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antiik91 @vesameskanen