Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

via point routing mvp #5191

Merged
merged 6 commits into from
Dec 13, 2024
Merged

via point routing mvp #5191

merged 6 commits into from
Dec 13, 2024

Conversation

tkalvas
Copy link
Contributor

@tkalvas tkalvas commented Dec 9, 2024

Proposed Changes

  • via point routing is returned to the extent that otp2 allows it
    • passthrough routing only
    • have to type a station/stop name manually, cannot point and click

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@tkalvas tkalvas marked this pull request as draft December 9, 2024 14:09
@tkalvas tkalvas marked this pull request as ready for review December 10, 2024 14:50
@vesameskanen vesameskanen merged commit cc18d1a into v3 Dec 13, 2024
6 checks passed
@vesameskanen vesameskanen deleted the via-point-mvp branch December 13, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants