Fix navigator translations and scheduled departure info #5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vesameskanen
commented
Dec 27, 2024
•
vesameskanen
commented
- Transit mode expressions now obey finnish grammar
- Ferry pier added as an alternative to stop / station expressions
- Some translation ids were obscure or indicated incorrect context, fixed
- Earlier design was not to show non-realtime departure warning if transit connection had not been moving 2 minutes. This lead to situation where no schedule information was shown for non-realtime departures from first stop. Fixed by changing the card from warning to info type.
Navi should show something when transit is departing from its first stop without realtime.
Remove the word 'from' from mode expression
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.