Add option to limit number of buckets #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a/multiprocessing_hpu
kzawora-intel
changed the title
madamczykhabana
requested changes
Aug 28, 2024
There was a problem hiding this comment.
I love the general idea of using exponential spacing for buckets, but the current implementation is very complex + it has some small issues like:
- what if we need a bucket that hasn't been warmed-up?
- as far as I can see we always call warmup_range_with_limit without specifying fill. Is it needed?
Let's discuss it offline and figure out how to simplify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.