forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mask based BGMV implementation #223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekgoe
requested changes
Sep 2, 2024
hlahkar
force-pushed
the
dev/hlahkar/bgmv_poc
branch
2 times, most recently
from
September 2, 2024 10:43
de3f36c
to
a8f1d7d
Compare
vivekgoe
approved these changes
Sep 2, 2024
hlahkar
force-pushed
the
dev/hlahkar/bgmv_poc
branch
from
September 4, 2024 04:00
8734f8f
to
49ffde6
Compare
hlahkar
force-pushed
the
dev/hlahkar/bgmv_poc
branch
2 times, most recently
from
September 4, 2024 10:56
881ef3f
to
f0f56fd
Compare
hlahkar
force-pushed
the
dev/hlahkar/bgmv_poc
branch
from
September 4, 2024 11:01
f0f56fd
to
538c8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors BGMV implementation from gather based to mask-based to optimize performance and reduce device memory usage.