Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lora manager tests #315

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Fixed lora manager tests #315

merged 6 commits into from
Oct 1, 2024

Conversation

rsshaik1
Copy link

Added the hpu related changes along with gpu to conftest.py file and test_lora_manager_hpu.py

@michalkuligowski michalkuligowski added the habana Issues or PRs submitted by Habana Labs label Sep 24, 2024
@vivekgoe
Copy link

@rsshaik1 please rebase PR to latest HabanaAI/vllm-fork and also take care of review comments.

Copy link

@vivekgoe vivekgoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @michalkuligowski ok to merge this?

tests/lora/conftest.py Outdated Show resolved Hide resolved
tests/lora/conftest.py Outdated Show resolved Hide resolved
tests/lora/conftest.py Outdated Show resolved Hide resolved
@vivekgoe vivekgoe merged commit c7b1509 into habana_main Oct 1, 2024
17 checks passed
@michalkuligowski michalkuligowski deleted the lora_manager_tests branch October 8, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
habana Issues or PRs submitted by Habana Labs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants