Refine INC shutdown code #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vllm/worker/habana_model_runner.py
Outdated
Comment on lines
1943
to
1958
| from operator import attrgetter | ||
| can_finalize_inc = False | ||
| try: | ||
| is_inc_used = attrgetter("model_config.quantization")( | ||
| self) == 'inc' | ||
| is_model_initialized = attrgetter("model.model")(self) is not None | ||
| is_inc_initialized = attrgetter("inc_initialized_successfully")( | ||
| self) | ||
| can_finalize_inc = is_inc_used and is_model_initialized and \ | ||
| is_inc_initialized | ||
| except AttributeError: | ||
| pass | ||
| if can_finalize_inc: | ||
| from neural_compressor.torch.quantization import ( | ||
| finalize_calibration) | ||
| finalize_calibration(self.model.model) |
There was a problem hiding this comment.
Oh, I thought attrgetter can handle AttributeErrors ...
So what's the point of using it at the moment? Since we're catching the exception, couldn't we do:
try:
is_inc_used = self.model_config.quantization == 'inc'
is_model_initialized = self.model.model is not None
is_inc_initialized = self.inc_initialized_successfully
can_finalize_inc = is_inc_used and is_model_initialized and \
is_inc_initialized
except AttributeError:
passor even better:
can_finalize_inc = (self.model_config.quantization == 'inc') and \
(self.model.model is not None) and \
self.inc_initialized_succesfullyThere was a problem hiding this comment.
fixed + added protection against double shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes debug printouts in INC shutdown method and covers the case where application exits before model is initialized properly.