Lora Mask based on lora index #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vllm/worker/habana_model_runner.py
Outdated
| end_pos = start_pos + self.lora_config.max_lora_rank | ||
| lora_mask[i, start_pos:end_pos] = ones | ||
| lora_mask = lora_mask.to('hpu') | ||
| lora_logits_mask = lora_mask |
There was a problem hiding this comment.
Could you explain why now logits mask is pointing to mask, before it was left None for decode phase.
Is that because now in line 1906 there can be reference to an object that is None? If so I would rather add there check if lora_logits_mask is not none instead of changing the logic of what lora_logits_mask is keeping
There was a problem hiding this comment.
@michalkuligowski for decode phase lora_mask and logits_mask are same; previously we were setting it at execute_model; just moved to create_lora_mask for a cleaner code
hlahkar
force-pushed
the
dev/hlahkar/lora_index_fix
branch
7 times, most recently
from
cdee227
to
c2572b9
Compare
vivekgoe
requested changes
Oct 1, 2024
vivekgoe
added
habana
hlahkar
force-pushed
the
dev/hlahkar/lora_index_fix
branch
from
c2572b9
to
cafde9c
Compare
hlahkar
force-pushed
the
dev/hlahkar/lora_index_fix
branch
from
cafde9c
to
9d62244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the filling of lora mask from lora_id to lora_index. This is needed to ensure that the mask does not fail in case lora id is greater than max_loras