Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Rename components *Habana* -> *HPU* #359

Merged
merged 6 commits into from
Oct 4, 2024
Merged

[Refactor] Rename components *Habana* -> *HPU* #359

merged 6 commits into from
Oct 4, 2024

Conversation

kzawora-intel
Copy link

@kzawora-intel kzawora-intel commented Oct 4, 2024 •
edited
Loading

Refactoring Gaudi-specific components to use hpu name instead of habana (e.g. habana_model_runner.py -> hpu_model_runner.py, habana_executor.py -> hpu_executor.py, etc.), as suggested in the upstream PR.

@mswiniarsk
Copy link

mswiniarsk commented Oct 4, 2024 •
edited
Loading

There are still references to the old names e.g. in Readme:
README_GAUDI.md:INFO 08-02 17:37:54 habana_worker.py:134] Model profiling run took 504 MiB of device memory (15.46 GiB/94.62 GiB used) and 180.9 MiB of host memory (475.4 GiB/1007 GiB used)
or installation doc:
docs/source/getting_started/gaudi-installation.rst: INFO 08-01 21:37:59 habana_model_runner.py:504] Decode bucket config (min, step, max_warmup) bs:[1, 128, 4], seq:[128, 128, 2048]

I believe there is no need to re-generate the logs, but would be good to perform "Replace All" occurrences in those logs so that its aligned. What do you think?

@kzawora-intel kzawora-intel merged commit cfe231d into habana_main Oct 4, 2024
17 checks passed
@kzawora-intel kzawora-intel mentioned this pull request Oct 4, 2024
Merged
michalkuligowski pushed a commit that referenced this pull request Oct 7, 2024
@kzawora-intel
[Refactor] Rename HabanaAttention -> HPUAttention (#362)
ad08dd4 
I've missed the attention backend in
#359
@kzawora-intel kzawora-intel deleted the private/kzawora/habana_hpu_refactor branch October 7, 2024 12:51
@kzawora-intel kzawora-intel added the habana Issues or PRs submitted by Habana Labs label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswiniarsk mswiniarsk mswiniarsk approved these changes

Assignees
No one assigned
Labels
habana Issues or PRs submitted by Habana Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzawora-intel @mswiniarsk