Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vllm_hpu_extension commit to 24039a3 #490

Open
wants to merge 2 commits into
base: habana_main
Choose a base branch
from

Conversation

ccrhx4
Copy link

@ccrhx4 ccrhx4 commented Nov 13, 2024

to fix part of the #443

update the vllm_hpu_extension commit id to HabanaAI/vllm-hpu-extension@24039a3

requirements-hpu.txt Outdated Show resolved Hide resolved
Copy link

@madamczykhabana madamczykhabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert for PR26 is pending: HabanaAI/vllm-hpu-extension#31

@michalkuligowski
Copy link

This needs to be rejected due to: HabanaAI/vllm-hpu-extension#31

@ccrhx4
Copy link
Author

ccrhx4 commented Nov 15, 2024

Inference accuracy is at the risk of being compromised when the softmax_mode == "fast".

From the Habana document, https://docs.habana.ai/en/latest/PyTorch/Model_Optimization_PyTorch/Optimization_in_PyTorch_Models.html#using-fused-sdpa

Using fast Softmax may affect inference accuracy.
Only BF16 data type is supported with fast Softmax.
Fast Softmax is not supported when running training in recompute mode with is_causal = False.

Even in the optimum-habana, the softmax_mode is default as "None". https://github.com/huggingface/optimum-habana/blob/f488ab66329b2c3a46063292b2822c1cab068756/optimum/habana/transformers/generation/configuration_utils.py#L38

Please reconsider this issue, I understand the performance is important, but the model needs to be performed correctly as it has been trained to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants