Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Prototype of User Service #15

Merged
merged 9 commits into from
Aug 21, 2023
Merged

Initial Prototype of User Service #15

merged 9 commits into from
Aug 21, 2023

Conversation

AydanPirani
Copy link
Contributor

Very very rudimentary approach to user service (supports getting users and updating data).

Should be OK to merge for now, but will need more work in the future (especially with QR code stuff + pagination)

@lasyaneti lasyaneti self-requested a review August 15, 2023 16:37
lasyaneti
lasyaneti previously approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@lasyaneti lasyaneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some things we should discuss: POST use cases/allowing request from any user; looking into transactions when CRUD-ing with Mongo (like the old API)

@lasyaneti lasyaneti self-requested a review August 17, 2023 06:26
lasyaneti
lasyaneti previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@lasyaneti lasyaneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial prototype lgtm

@lasyaneti lasyaneti self-requested a review August 17, 2023 19:36
@lasyaneti
Copy link
Contributor

lasyaneti commented Aug 18, 2023 •
edited by AydanPirani
Loading

Testing these using staff auth token

  • GET and POST / with edge cases
  • GET /:USERID with edge cases
  • GET /qr/
  • GET /qr/:USERID with edge cases

@lasyaneti lasyaneti self-requested a review August 18, 2023 00:17
@AydanPirani AydanPirani merged commit f40d5a0 into main Aug 21, 2023
2 checks passed
@AydanPirani AydanPirani deleted the dev/aydan/user-service branch August 21, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasyaneti lasyaneti lasyaneti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AydanPirani @lasyaneti