react1-week3/nishadi #311
Open
react1-week3/nishadi #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babak-f
approved these changes
Jan 28, 2024
| date.setHours(0, 0, 0, 0) | ||
|
|
||
| if (deadline < date) { | ||
| return window.alert('Please select a deadline in present or future') |
There was a problem hiding this comment.
Since handleSubmit does not expect a return value, you can rewrite this into:
alert('...');
return;
Here the purpose of the return statement will be simply to stop executing the rest of the function, which is correct.
| /> | ||
| <br /> | ||
| <label >Deadline</label> | ||
| <div> |
There was a problem hiding this comment.
You don't need the div here, since it is not doing anything.
|
|
||
| const deadLineText = `${date.getFullYear()}-${date.getMonth()+1}-${date.getDate()}` | ||
|
|
||
| const decorateDone = props.done ? |
| } | ||
|
|
||
| return ( | ||
| <li key={props.taskId} className="todoItem"> |
There was a problem hiding this comment.
As a convention, class names are always written in kebab case (https://developer.mozilla.org/en-US/docs/Glossary/Kebab_case).
| ); | ||
| } | ||
|
|
||
| TodoItem.propTypes = { |
| const onAddNewTask = (description, deadline) => { | ||
| const newTask = { | ||
| id: new Date().getTime(), | ||
| description: description, |
There was a problem hiding this comment.
Optional: since both sides are called description, you can just write it once, i.e. description, .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my homework.