Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #49

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update README.md #49

wants to merge 2 commits into from

Conversation

liya-oz
Copy link

@liya-oz liya-oz commented Sep 5, 2024

- Deleted old links:(https://shubhamrath.dev/lterm/) and (https://github.com/HackYourFutureBelgium/replicate-this-from-command-line) 
 instead 
- Added similar interactive online sources 
- Moved the Terminus game to the "Games" chapter  and added a new link: [Terminal Temple: an interactive online terminal simulator](https://www.terminaltemple.com) to the "Extra reading"
-Corrected some words to use title case.
- Added a responsive YouTube video link using Markdown with embedded HTML. The previous template tag or shortcode syntax was lost after forking.
Copy link

@allhandsondeck allhandsondeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort 👏🏼

@@ -8,25 +8,27 @@ As a beginning developer it's important to get familiar with it, as it will teac

Follow along with the following video (the video is for the MacOS terminal, so if you are on windows you can use your Git Bash and run the same commands):

{% hyf-youtube src="https://www.youtube.com/watch?v=5XgBd6rjuDQ" %}
{% hyf-youtube src=https://www.youtube.com/watch?v=5XgBd6rjuDQ %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert it back to the regular quotes? From my experience, using a different type of symbol can mess up things

Copy link
Author

@liya-oz liya-oz Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @stasel , I can revert to regular quotes, but this will open a smaller YouTube player, which isn’t as as nice-looking. The current quote was part of the original code and is used in the HYF book, displaying a full-width video player. This repository uses this style of quotes for YouTube videos throughout.

If you prefer, I can change to regular quotes.

or

it is possible to use Markdown with embedded HTML for a responsive video link:

<div style="width: 100%; max-width: 100vw;">
     <a href="https://www.youtube.com/watch?v=5XgBd6rjuDQ" target="_blank">
         <img src="https://img.youtube.com/vi/5XgBd6rjuDQ/0.jpg" alt="Video Terminal Basics for Beginners" style="width: 100%; height: auto;"/>
     </a>
</div>

or we can leave it as it is.

Whatever you prefer.

@liya-oz liya-oz requested a review from stasel September 9, 2024 11:53
@liya-oz liya-oz marked this pull request as draft September 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants