Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable different initial angle for circular slider. #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iblagajic
Copy link

@iblagajic iblagajic commented Mar 25, 2019

This PR addresses the issue #20: Setting the start position.

It is based on solution by @spaluchiewicz and this PR. I was unable to update the existing PR due to the access rights so I'm setting up a new one.
Commits are squashed to keep it clean, but @spaluchiewicz is kept as the coauthor. I hope this is fine.

In addition to setting the new position, I also tweaked the current implementation so that user can't swipe over the maximum and under the minimum value. Please let me know if you think it's appropriate or if we should make it a property that can be set. (Issue #10 )

@HamzaGhazouani
Copy link
Owner

thanks @iblagajic, I will review it this week-end

@danibachar
Copy link

👍 any updates?

@realityworks
Copy link

Would be good to get this in, otherwise we will Cherry Pick these changes into our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants