Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from autowarefoundation:main #17

Merged
merged 10 commits into from
Dec 8, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 6, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

TaikiYamada4 and others added 3 commits December 6, 2023 15:25
…asurementPose/Twist (#5691)

* Added X_delay_times_ to obtain the accumulated lap times of the timer callback.
Added find_closest_index function to easily use the X_delay_times_.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* Added a concept/variable of accumulated_delay_time_ and store every lap time of timer callback.
The delay_step will be calculated from it, and the bug of calculating delay_step should be gone.
Besides, removed dt in measurementUpdatePose/Twist since it is not needed.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* Fixed dt to ekf_dt_ in predictUpdateFrequency()

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* Removed temporary debug stuff

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* style(pre-commit): autofix

* Fixed code style pointed out from pre-commit.ci

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* style(pre-commit): autofix

* Fixed typo

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* Removed variable ekf_rate_ which is currently unused.
Added warnings when the ekf_dt_ is too large.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* style(pre-commit): autofix

* Changed threshold of delay time so that to look the most last (or largest) value of accumulated_delay_times_

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* Correct the warning messages of diag_info to look up the last (or largest) value of accumulated_delay_times_

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1. The `updateData()` function now sets `status_.is_safe_dynamic_objects` to true when `requiresDynamicObjectsCollisionDetection()` returns false.

2. The `isExecutionReady()` function now checks for dynamic object collisions only if `requiresDynamicObjectsCollisionDetection()` returns true and `isWaitingApproval()` also returns true. This change ensures that dynamic object collision detection is performed only when necessary and approval is pending.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
* feat(start_planner): add surround moving obstacle check
This commit introduces a new feature in the start_planner module for checking surrounding moving obstacles.
- It adds parameters to specify the search radius and threshold velocity for moving obstacles, along with flags to indicate which types of objects should be checked.
- The `noMovingObjectsAround` function has been added to filter dynamic objects within a certain radius based on their velocity.
  - If no moving objects are detected, the function returns true; otherwise, it returns false.
- This feature enhances the safety of the start_planner by ensuring that the path can't be approved while surrond moving obstacles exist.
---------
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
satoshi-ota and others added 2 commits December 7, 2023 10:33
* refactor(avoidance): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(AbLC): separate package

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove separate module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(bpp): fix test error

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: github-actions <github-actions@github.com>
zulfaqar-azmi-t4 and others added 5 commits December 7, 2023 11:30
…5758)

* refactor(motion_velocity_smoother): boost::optional to std::optional

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* separate packages

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
delete unnecessary TODO

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@HansRobo HansRobo changed the base branch from main to use-nvidia-image December 8, 2023 01:02
@HansRobo HansRobo merged commit 8198340 into HansRobo:use-nvidia-image Dec 8, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants