Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add responsive for mobile #64

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

alfanzain
Copy link
Contributor

@alfanzain alfanzain commented Jul 17, 2024

Issue
This PR solves #63 (hopefully)

What I Did

  • Move HUD or scene according to desktop / mobile screen
  • Resize HUD, entity, or scene according to the screen
  • Test the scenes on almost all screen (desktop, tablet, mobile)

Evidences

Mobile:
image
image
image
image
image
image

Desktop:
image
image
image
image
image
image

@riandyrn
Copy link
Collaborator

Hello, @alfanzain

Thanks for your PR!

However, when I tried to run your PR locally by using make run, I always get these errors:

Screenshot 2024-07-17 at 21 48 42

Screenshot 2024-07-17 at 21 49 37

When I tried to remove both max-[1060px]:w-full & max-[325px]:text-4xl the error disappears.

Maybe you know something about this condition?

@alfanzain
Copy link
Contributor Author

Hello @riandyrn thanks for the reply!

I can't really reproduce the issue, maybe this commit can solve it.
Since using arbitrary is a bit confusing in some cases.

e5fe335

Thank you for your time to review this PR!

Copy link
Collaborator

@riandyrn riandyrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's working fine. Thanks a lot, @alfanzain! 👍🏻

Finally we have demo that can run on mobile! 🎉🎉🎉

@riandyrn riandyrn merged commit 6595e47 into Haraj-backend:master Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants