Fix: Error 409 When Starting Battle using Rest Memory Variant #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when there is no record in the memory;
…if game is not exists GetGame() will return nil;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run the system using
make runcommand & start a new game, it prevents me from starting a battle like this:Yet, the scenario status is correct, which is
BATTLE_1:Upon investigation, I found that the current implementation of
GetBattle()in memory battle storage is not returning nil but an empty object when the service interface expects it to return nil. So, I fix this in this PR.I also noticed the
GetGame()implementation in memory game storage is in the same situation, so I fixed it in this PR.