Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a root .dockerignore to prevent node_modules from being copied #15

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Ethan-Arrowood
Copy link
Contributor

Noticed node_modules was getting included in the COPY operations for fixtures which could cause build issues if there were symlinks within it.

Unfortunately docker doesn't let me pass a dockerignore path to the build command, it just must be present in the build context directory (which is the root of the repo for all build ops).

I'd like to eventually move to a colocated dockerfile setup (dockerfile will be located within the fixture itself) and that will clean this up some more. But that requires more work than this easy fix.

@Ethan-Arrowood Ethan-Arrowood requested a review from a team December 6, 2024 16:59
Copy link

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ethan-Arrowood Ethan-Arrowood merged commit b72c05e into main Dec 6, 2024
1 check passed
@Ethan-Arrowood Ethan-Arrowood deleted the ignore-node-modules branch December 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants