-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/robust visualization #5
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a76fee2 - Browse repository at this point
Copy the full SHA a76fee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee197db - Browse repository at this point
Copy the full SHA ee197dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23a1e41 - Browse repository at this point
Copy the full SHA 23a1e41View commit details -
refactor: Use np.nanmax instead of np.max for calculating axis limits…
… in SpotDiagram class
Configuration menu - View commit details
-
Copy full SHA for 8824410 - Browse repository at this point
Copy the full SHA 8824410View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8e6d5d - Browse repository at this point
Copy the full SHA f8e6d5dView commit details -
refactor: Modify LensViewer3D class to plot lenses and surfaces using…
… x, y, and z coordinates
Configuration menu - View commit details
-
Copy full SHA for ae35d79 - Browse repository at this point
Copy the full SHA ae35d79View commit details -
Configuration menu - View commit details
-
Copy full SHA for b765f23 - Browse repository at this point
Copy the full SHA b765f23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bf6151 - Browse repository at this point
Copy the full SHA 8bf6151View commit details -
Configuration menu - View commit details
-
Copy full SHA for df62bd2 - Browse repository at this point
Copy the full SHA df62bd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3d2439 - Browse repository at this point
Copy the full SHA a3d2439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4be64df - Browse repository at this point
Copy the full SHA 4be64dfView commit details
Commits on Sep 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 383b0c8 - Browse repository at this point
Copy the full SHA 383b0c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0778e1 - Browse repository at this point
Copy the full SHA c0778e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ff1a8 - Browse repository at this point
Copy the full SHA e2ff1a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd4ea6 - Browse repository at this point
Copy the full SHA dcd4ea6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b818383 - Browse repository at this point
Copy the full SHA b818383View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93eb9cf - Browse repository at this point
Copy the full SHA 93eb9cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d4f7a7 - Browse repository at this point
Copy the full SHA 3d4f7a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1174ac1 - Browse repository at this point
Copy the full SHA 1174ac1View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b32feb7 - Browse repository at this point
Copy the full SHA b32feb7View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 68225d2 - Browse repository at this point
Copy the full SHA 68225d2View commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a2c007 - Browse repository at this point
Copy the full SHA 9a2c007View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5834196 - Browse repository at this point
Copy the full SHA 5834196View commit details -
Configuration menu - View commit details
-
Copy full SHA for d10d1d4 - Browse repository at this point
Copy the full SHA d10d1d4View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d58d49f - Browse repository at this point
Copy the full SHA d58d49fView commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98e5a79 - Browse repository at this point
Copy the full SHA 98e5a79View commit details -
refactor: complete rewrite of LensViewer to improve robustness and ma…
…ke plotting generic for any coordinate systems
Configuration menu - View commit details
-
Copy full SHA for 11dd1d5 - Browse repository at this point
Copy the full SHA 11dd1d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5cf05a - Browse repository at this point
Copy the full SHA a5cf05aView commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 645d1ef - Browse repository at this point
Copy the full SHA 645d1efView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ccdd98 - Browse repository at this point
Copy the full SHA 7ccdd98View commit details
Commits on Oct 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2d8a7b - Browse repository at this point
Copy the full SHA b2d8a7bView commit details
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 35de93e - Browse repository at this point
Copy the full SHA 35de93eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6bf32a - Browse repository at this point
Copy the full SHA c6bf32aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d812a8f - Browse repository at this point
Copy the full SHA d812a8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2f7862 - Browse repository at this point
Copy the full SHA b2f7862View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbeac98 - Browse repository at this point
Copy the full SHA bbeac98View commit details -
feat: Add Surface2D and Surface3D classes for visualizing surfaces in…
… 2D and 3D This commit adds the Surface2D and Surface3D classes to the optiland.visualization.surface module. These classes are used for visualizing surfaces in 2D and 3D respectively. The Surface2D class plots the surface on a matplotlib axis, while the Surface3D class plots the surface using VTK renderer. Both classes have methods to compute the sag of the surface and handle physical apertures if present. The Surface2D class takes a Surface object and an extent tuple as arguments, and the Surface3D class takes a Surface object and an extent tuple as well. The Surface2D class plots the surface on a matplotlib axis using the _compute_sag method, and the Surface3D class plots the surface using VTK renderer by creating a polydata object, applying Delaunay triangulation, and mapping the surface to a VTK actor. The Surface3D class also has a _configure_material method to configure the material properties of the VTK actor. This commit enhances the visualization capabilities of the optiland library and provides a convenient way to visualize surfaces in 2D and 3D.
Configuration menu - View commit details
-
Copy full SHA for ffe1ccb - Browse repository at this point
Copy the full SHA ffe1ccbView commit details -
feat: Add Mirror3D class for visualizing 3D mirror surfaces
Add a new class, Mirror3D, to represent a 3D mirror surface in the optiland.visualization module. This class inherits from the Surface3D class and provides methods for configuring the material properties of the mirror surface. The Mirror3D class takes a mirror surface and an extent as arguments in its constructor. The _configure_material method is used to set the color, ambient, diffuse, specular, and specular power properties of the mirror surface actor. This commit adds the Mirror3D class to the optiland.visualization.mirror module.
Configuration menu - View commit details
-
Copy full SHA for 2b7ddd7 - Browse repository at this point
Copy the full SHA 2b7ddd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b15b5e9 - Browse repository at this point
Copy the full SHA b15b5e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cdd166 - Browse repository at this point
Copy the full SHA 5cdd166View commit details -
Configuration menu - View commit details
-
Copy full SHA for af96347 - Browse repository at this point
Copy the full SHA af96347View commit details -
Configuration menu - View commit details
-
Copy full SHA for 694e3b2 - Browse repository at this point
Copy the full SHA 694e3b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9d31f6 - Browse repository at this point
Copy the full SHA e9d31f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b7a28 - Browse repository at this point
Copy the full SHA 92b7a28View commit details -
Configuration menu - View commit details
-
Copy full SHA for de826cc - Browse repository at this point
Copy the full SHA de826ccView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d8560c - Browse repository at this point
Copy the full SHA 5d8560cView commit details -
refactor: Refactor Lens3D class and visualization methods
Refactor the Lens3D class in lens.py to improve code organization and readability. The changes include: - Adding a nested Lens3D class with proper documentation and attributes - Implementing the is_symmetric method to check if all surfaces in the lens are symmetric - Refactoring the plot method to handle both symmetric and non-symmetric lenses - Adding helper methods for plotting single lenses and configuring material properties - Refactoring the _plot_surfaces method to compute sag values and plot the surfaces - Adding the _get_edge_surface method to generate VTK actors representing the surface between two circles - Refactoring the _plot_surface_edges method to calculate the maximum extent of the surfaces and plot circular edges These changes improve the overall structure and maintainability of the Lens3D class and its visualization methods.
Configuration menu - View commit details
-
Copy full SHA for 8f1eb85 - Browse repository at this point
Copy the full SHA 8f1eb85View commit details -
refactor: Refactor Surface3D class to improve surface plotting
The Surface3D class in surface.py has been refactored to improve the plotting of 3D surfaces. The changes include: - Moving the initialization of the Surface2D superclass to the Surface3D constructor - Adding a get_surface() method to retrieve the surface actor based on the symmetry of the surface geometry - Splitting the plot() method into separate methods for generating symmetric and asymmetric surface actors - Adding a _configure_material() method to configure the material properties of the surface actor - Converting the surface actor to global coordinates after generating it These changes enhance the flexibility and readability of the Surface3D class, making it easier to plot both symmetric and asymmetric surfaces.
Configuration menu - View commit details
-
Copy full SHA for 45b325e - Browse repository at this point
Copy the full SHA 45b325eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9a3169 - Browse repository at this point
Copy the full SHA d9a3169View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1b969f - Browse repository at this point
Copy the full SHA c1b969fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1e01a7 - Browse repository at this point
Copy the full SHA e1e01a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c1fe9 - Browse repository at this point
Copy the full SHA 40c1fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0591f11 - Browse repository at this point
Copy the full SHA 0591f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 014228d - Browse repository at this point
Copy the full SHA 014228dView commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 604314b - Browse repository at this point
Copy the full SHA 604314bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e082bf8 - Browse repository at this point
Copy the full SHA e082bf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6a5fc1 - Browse repository at this point
Copy the full SHA e6a5fc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f63c647 - Browse repository at this point
Copy the full SHA f63c647View commit details -
Configuration menu - View commit details
-
Copy full SHA for d05f11b - Browse repository at this point
Copy the full SHA d05f11bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c12f66 - Browse repository at this point
Copy the full SHA 3c12f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e5900 - Browse repository at this point
Copy the full SHA b1e5900View commit details -
refactor: Update OpticViewer3D class to handle rendering window and i…
…nteractor This commit updates the OpticViewer3D class in the visualization module. It adds instance variables for the render window and interactor, and modifies the view method to use these variables. This change improves the code organization and makes it easier to manage the rendering window and interactor in the 3D viewer. Refactor the OpticViewer3D class to handle the rendering window and interactor.
Configuration menu - View commit details
-
Copy full SHA for ce63a34 - Browse repository at this point
Copy the full SHA ce63a34View commit details -
Configuration menu - View commit details
-
Copy full SHA for df116e6 - Browse repository at this point
Copy the full SHA df116e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8332b54 - Browse repository at this point
Copy the full SHA 8332b54View commit details