Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate non deprecated metadata #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Generate non deprecated metadata #1377

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceb01c3
Generate non deprecated metadata
riccardo-aolis Aug 27, 2022
f16675f
Check if the network is solana
Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,7 @@ const addMetadata = (_dna, _edition) => {
symbol: solanaMetadata.symbol,
description: tempMetadata.description,
//Added metadata for solana
seller_fee_basis_points: solanaMetadata.seller_fee_basis_points,
image: `${_edition}.png`,
//Added metadata for solana
external_url: solanaMetadata.external_url,
edition: _edition,
...extraMetadata,
attributes: tempMetadata.attributes,
Expand All @@ -161,9 +158,7 @@ const addMetadata = (_dna, _edition) => {
uri: `${_edition}.png`,
type: "image/png",
},
],
category: "image",
creators: solanaMetadata.creators,
]
},
};
}
Expand Down Expand Up @@ -314,6 +309,8 @@ const saveMetaDataSingleFile = (_editionCount) => {
`Writing metadata for ${_editionCount}: ${JSON.stringify(metadata)}`
)
: null;

delete metadata.edition;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you delete it, when you can just delete the line what includes this data?

What's the point of add edition and then delete edition?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edition is used on saveMetaDataSingleFile as well, as a reference to get the right set of data.
You could edit saveMetaDataSingleFile and use the name of the image for instance, or change the structure of it but mine was just a quick fix.

One thing that I got wrong is that it's necessary an if statement to check if the network is solana.
See review below.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
delete metadata.edition;
if(network === NETWORK.sol) delete metadata.edition;

fs.writeFileSync(
`${buildDir}/json/${_editionCount}.json`,
JSON.stringify(metadata, null, 2)
Expand Down