Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pitch to FlxSound demo #358

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

ACrazyTown
Copy link
Contributor

Adds a numeric stepper for the pitch property on every target except flash

one more conditional...

another one whoops

Add pitch to FlxSound demo
@ACrazyTown
Copy link
Contributor Author

btw unrelated but I've noticed that HTML5 builds seem to include both mp3 and ogg files, despite the code only using mp3 on flash. is this an oversight?

@Geokureli
Copy link
Member

Geokureli commented Oct 7, 2024

btw unrelated but I've noticed that HTML5 builds seem to include both mp3 and ogg files, despite the code only using mp3 on flash. is this an oversight?

does ogg work on most browsers?
Edit: Yes. feel free to fix that here or in another PR

@ACrazyTown
Copy link
Contributor Author

should be good to go now i think

@Geokureli Geokureli merged commit 16de61c into HaxeFlixel:dev Oct 8, 2024
8 checks passed
@Geokureli
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants