Stricter checks for FlxG.bitmap.maxTextureSize

[ACrazyTown]

Checks if any of the Lime OpenGL defines are defined & also checks if FlxG.stage.window is hardware accelerated

[Geokureli]

Can we add a new define to FlxDefines.HelperDefines, instead? like FLX_HAS_MAX_TEXTURE_SIZE or something?

[ACrazyTown]

Can we add a new define to FlxDefines.HelperDefines, instead? like FLX_HAS_MAX_TEXTURE_SIZE or something?

I was thinking about that too, would make things a lot cleaner to manage.

Also, would it be better to use Null<Int> instead of returning -1 when it's not possible to get the max texture size?

[Geokureli]

Also, would it be better to use Null<Int> instead of returning -1 when it's not possible to get the max texture size?

I know -1 isn't a great solution, but I rarely think Null is much better, compared to say, enums. either way, lets stick with -1 rather than introducing a potentially breaking change

I'll test this PR soon

[ACrazyTown]

I know -1 isn't a great solution, but I rarely think Null is much better, compared to say, enums. either way, lets stick with -1 rather than introducing a potentially breaking change

Is it a breaking change if right now trying to access FlxG.bitmap.maxTextureSize on software rendered/non-OpenGL builds will result in a crash because the GL context isn't available?

[ACrazyTown]

Also, I was thinking of adding a check in FlxGraphic to warn users if they were making graphics that were larger than maxTextureSize, could I sneak that in here or should that be a seperate PR?

[Geokureli]

go for it

[Geokureli]

What kind of rendering issues will happen? I'm debating whether this should be an error or not

[ACrazyTown]

From my understanding OpenGL won't upload the texture to the GPU at all and any attempts to render the texture will be replaced with a fallback texture (usually just black or whatever), probably should be an error yeah

[ACrazyTown]

Idk why CI failed

[Geokureli]

The CI failure seems unrelated, I usually just rerun them

[Geokureli]

The remaining CI failures DO seem related. I'll have to try unit tests locally. For now I'll rerun the jobs, again, just in case it's nothing

[ACrazyTown]

Would it be better to check if FlxG.stage.window.context.attributes.hardware (or whatever part of it that fails) is defined rather than outright skipping it?

[Geokureli]

I don't think so. If it's not defined in any other context I want it to fail loudly, and I don't think we can really unit test gl stuff right now

[Geokureli]

Thanks!