Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Vue Zoomable Component & Scrolloverlay #1

Open
wants to merge 3 commits into
base: refactor2
Choose a base branch
from
Open

Refactor Vue Zoomable Component & Scrolloverlay #1

wants to merge 3 commits into from

Conversation

Robinrrr
Copy link

Description

These changes remove the extra Vue instance that is created in the VueZoomable component. There are also improvements in the ScrollOverlay component

Type of change

  • Additional Vue Instance in VueZoomable.vue was removed. The ScrollOverlay was added in the component itself.
  • Show the ScrollOverlay text only if wheelEnabled is true. It makes no sense to display the text if you have deactivated it
  • Rename the enableWheelOnKey property to wheelKey for better understanding
  • Re-Formatting some code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robinrrr @robinrr3