Skip to content

Commit

Permalink
Async update in product editor to prevent deadlock
Browse files Browse the repository at this point in the history
Reported in eclipse-pde#907 that loading of target platform and de-selecting it in
the preference can lead to a deadlock. With this change the update of
the ProductInfoSection happens with async.

Fixes eclipse-pde#907
  • Loading branch information
vogella committed Nov 15, 2023
1 parent dc480ed commit f169a74
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ public void registryChanged(IRegistryChangeEvent event) {
if (applicationDeltas.length + productDeltas.length == 0) {
return;
}
Display.getDefault().syncExec(() -> {
Display.getDefault().asyncExec(() -> {
fAppCombo.handleExtensionDelta(applicationDeltas);
fProductCombo.handleExtensionDelta(productDeltas);
});
Expand All @@ -427,7 +427,7 @@ public void stateChanged(State newState) {
System.arraycopy(apps, 0, finalApps, 0, apps.length);
finalApps[apps.length] = ""; //$NON-NLS-1$

Display.getDefault().syncExec(() -> {
Display.getDefault().asyncExec(() -> {
fAppCombo.reload(finalApps);
fProductCombo.reload(finalProducts);
});
Expand Down

0 comments on commit f169a74

Please sign in to comment.