Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge java version into master #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mkerian10
Copy link

Adds java version, doing 5-9 card evaluation. Addresses issue #5

@HenryRLee
Copy link
Owner

Thanks @Mkerian10 for the hard work. Generally they look good to me. Just a few change requests, and then I'll merge this PR:

I see some binary files committed, as well as many cache files, history files and lock files. Do you think they should be deleted?

The other request is that can you change the package name from evaluator to phevaluator? So that the name matches the Python package name and C++ namespace.

@Thomas-MMJ
Copy link

Thomas-MMJ commented Apr 1, 2023

None of the files in .gradle should be merged, those are local build files that appear to have been committed by accident. Same with the folder gradle/wrapper.

Only the file java/build.gradle and the folder java/src (and all files and subdirectories of java/src) should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants