Add changelog item and test for matthew-brett#216

HexDecimal · Jun 7, 2024 · 06e8d39 · 06e8d39
1 parent 1af49a8
commit 06e8d39
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Changelog.md b/Changelog.md
@@ -21,6 +21,12 @@ rules on making a good Changelog.
   version to `delocate==0.11.0`.
   [#215](https://github.com/matthew-brett/delocate/pull/215)
 
+### Fixed
+
+- Existing libraries causing DelocationError were not shown due to bad string
+  formatting.
+  [#216](https://github.com/matthew-brett/delocate/pull/216)
+
 ## [0.11.0] - 2024-03-22
 
 ### Added

diff --git a/delocate/tests/test_delocating.py b/delocate/tests/test_delocating.py
@@ -365,7 +365,10 @@ def filt_func(libname: Text) -> bool:
         shutil.copy2(libb, "subtree")
         # If liba is already present, barf
         shutil.copy2(liba, "subtree")
-        assert_raises(DelocationError, copy_recurse, "subtree", filt_func)
+        with pytest.raises(
+            DelocationError, match=r".*liba.dylib .*already exists.*liba.dylib"
+        ):
+            copy_recurse("subtree", filt_func)
         # Works if liba not present
         os.unlink(pjoin("subtree", "liba.dylib"))
         copy_recurse("subtree", filt_func)