fix points for user page

Hexlet · Mar 28, 2024 · dd4f1f2 · dd4f1f2
1 parent 324c03d
commit dd4f1f2
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php
@@ -13,13 +13,12 @@ public function show(User $user, RatingCalculator $ratingCalculator): View
     {
         $rating = $ratingCalculator->calculate();
         $userInRating = $rating->get($user->id);
-        if ($userInRating) {
-            $points = $userInRating->points;
-            $position = $userInRating->position;
-        } else {
-            $points = 0;
-            $position = 'N/A';
-        }
+        $points = $user->points;
+
+        $position = $rating->has($user->id)
+            ? $userInRating->position
+            : 'N/A';
+
         $user->load('chapterMembers', 'exerciseMembers');
         $chart = ChartHelper::getChart($user->id);
         return view('user.show', compact(