This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Allow launching Puter apps from the Puter Terminal! #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell isn't visible, so it doesn't need these remnants from Terminal.
`process` only exists when running in Node. Notably, `if (process)` is still a ReferenceError, so the existing checks need modifying too.
Previously we were reading `config.source` and then removing the trailing slash. However, this doesn't include the port, which we use when running locally. `config['puter.api_origin']` is actually what we want, which does have the port if it's set, and doesn't include the trailing slash either.
|
I think this is complete now! Make sure to merge HeyPuter/terminal#9 at the same time. The only missing part is that Phoenix shows up as a blank window instead of being headless. I have PRs on here and Puter which solve that, but I'm not convinced that's a good way of doing it so I'm keeping those separate. As for launching apps, the support is basic: You launch them, you can't pass them any arguments, there's no stdio, and you immediately return to the shell prompt. But you can type app names and they run! (And they show up in |
AtkinsSJ
changed the title
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on a bunch of changes in a bunch of other repos. 😆
Main thing remaining is that this shows up as a blank window when Terminal is running.