Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ola: declare indirect deps with linkage #178091

Merged
merged 1 commit into from
Jul 22, 2024
Merged

ola: declare indirect deps with linkage #178091

merged 1 commit into from
Jul 22, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

https://github.com/Homebrew/homebrew-core/actions/runs/10029560127/job/27720329759?pr=177981#step:4:1117

@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Jul 22, 2024
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Jul 22, 2024
@chenrui333
Copy link
Member Author

chenrui333 commented Jul 22, 2024

  libtool: compile:  g++-11 -DHAVE_CONFIG_H -I. -I./include -I./include -Wall -Wformat -W -fvisibility-inlines-hidden -I/home/linuxbrew/.linuxbrew/Cellar/protobuf@21/21.12/include -DNDEBUG -std=gnu++11 -c plugins/pathport/PathportNode.cpp  -fPIC -DPIC -o plugins/pathport/.libs/PathportNode.o
  plugins/osc/OSCNode.cpp: In function ‘int ola::plugin::osc::OSCDataHandler(const char*, const char*, lo_arg**, int, void*, void*)’:
  plugins/osc/OSCNode.cpp:153:28: error: cannot convert ‘lo_arg*’ to ‘lo_blob’ {aka ‘lo_blob_*’} in initialization
    153 |       lo_blob blob = argv[0];
        |                      ~~~~~~^
        |                            |
        |                            lo_arg*
  plugins/osc/OSCNode.cpp: In member function ‘bool ola::plugin::osc::OSCNode::Init()’:
  plugins/osc/OSCNode.cpp:266:50: error: invalid conversion from ‘int (*)(const char*, const char*, lo_arg**, int, void*, void*)’ to ‘lo_method_handler’ {aka ‘int (*)(const char*, const char*, lo_arg**, int, lo_message_*, void*)’} [-fpermissive]
    266 |   lo_server_add_method(m_osc_server, NULL, NULL, OSCDataHandler, this);
        |                                                  ^~~~~~~~~~~~~~
        |                                                  |
        |                                                  int (*)(const char*, const char*, lo_arg**, int, void*, void*)
  In file included from /home/linuxbrew/.linuxbrew/Cellar/liblo/0.32/include/lo/lo.h:32,
                   from ./plugins/osc/OSCNode.h:24,
                   from plugins/osc/OSCNode.cpp:35:
  /home/linuxbrew/.linuxbrew/Cellar/liblo/0.32/include/lo/lo_lowlevel.h:876:72: note:   initializing argument 4 of ‘lo_method_* lo_server_add_method(lo_server, const char*, const char*, lo_method_handler, const void*)’
    876 |                                const char *typespec, lo_method_handler h,
        |                                                      ~~~~~~~~~~~~~~~~~~^

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. build failure CI fails while building the software upstream issue An upstream issue report is needed labels Jul 22, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>

ola: add liblo 0.32 header compat patch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
Copy link
Member Author

@chenrui333 chenrui333 removed upstream issue An upstream issue report is needed build failure CI fails while building the software labels Jul 22, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Jul 22, 2024
Merged via the queue into master with commit 371ae12 Jul 22, 2024
27 checks passed
@chenrui333 chenrui333 deleted the ola-linkage branch July 22, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants