dispatch-build-bottle: run brew update
#187575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
|
That'll be because it was dispatched in the 5 minute window that a PR was open. Could check open PRs but is it worth it? |
|
Could also I guess make the upload workflow wait for the PR to be merged and thus hold on to the concurrency lock. |
Bo98
approved these changes
Sep 12, 2024
ZhongRuoyu
reviewed
Sep 12, 2024
MikeMcQuaid
approved these changes
Sep 12, 2024
Still seeing duplicate bottle jobs: https://github.com/Homebrew/homebrew-core/actions/runs/10820149397 Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
This should also help mitigate duplicate build issues. We use `gh api` instead of `gh pr view` in order to minimise the number of API calls we have to make.
carlocab
force-pushed
the
dispatch-brew-update
branch
from
d8118d5
to
86e6ed9
Compare
Done the latter. |
ZhongRuoyu
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still seeing duplicate bottle jobs: https://github.com/Homebrew/homebrew-core/actions/runs/10820149397