workflows: pass --repo to relevant gh calls
#188086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letting `gh` infer the GitHub repository (e.g. from the working directory) makes it do extra API calls we don't need. Let's just pass `--repo` wherever we don't call `gh api` to avoid this. While we're here: - ensure this is done uniformly using `--repo "$GITHUB_REPOSITORY"` - remove more workflow interpolation into shell script, in line with GitHub documentation on security hardening[^1] [^1]: https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
github-actions
bot
added
workflows
Bo98
approved these changes
Sep 12, 2024
Think we already do do that in most places, but it doesn't seem to stop the extra API calls. |
MikeMcQuaid
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letting
ghinfer the GitHub repository (e.g. from the workingdirectory) makes it do extra API calls we don't need.
Let's just pass
--repowherever we don't callgh apito avoid this.While we're here:
--repo "$GITHUB_REPOSITORY"GitHub documentation on security hardening1
Footnotes
https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable ↩