Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

titan-server: disable #188478

Merged
merged 1 commit into from
Sep 13, 2024
Merged

titan-server: disable #188478

merged 1 commit into from
Sep 13, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Sep 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?


seeing

  ==> Downloading http://s3.thinkaurelius.com/downloads/titan/titan-1.0.0-hadoop1.zip
  curl: (6) Could not resolve host: s3.thinkaurelius.com
  ...

https://github.com/Homebrew/homebrew-core/actions/runs/10837005065/job/30072042509


stats:

image

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 12, 2024
@github-actions github-actions bot added java Java use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Sep 12, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Sep 12, 2024
@cho-m
Copy link
Member

cho-m commented Sep 12, 2024

In addition to deprecation, can add archive.org URLs so we can still build until we remove formula.

@chenrui333
Copy link
Member Author

we can build, but I dont think artifact does not work anymore? if you see the linked issue.

@cho-m
Copy link
Member

cho-m commented Sep 12, 2024

I wonder what is best way to apply our documentation on this:

Deprecated formulae should continue to be maintained by the Homebrew maintainers so they still build from source and their bottles continue to work (even if unmaintained upstream). If this is not possible, they should be disabled.

Or if our deprecation policy should be updated as it currently reads like we would directly disable it if it doesn't work.

@chenrui333
Copy link
Member Author

chenrui333 commented Sep 12, 2024

I am okay to disable it directly (considering the stats for the past year), it also kind of applying to #188498 as well

@chenrui333 chenrui333 changed the title titan-server: deprecate titan-server: disable Sep 12, 2024
@github-actions github-actions bot added formula disabled Formula disabled and removed formula deprecated Formula deprecated labels Sep 12, 2024
@chenrui333 chenrui333 requested review from cho-m and a team September 12, 2024 23:36
Formula/t/titan-server.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 13, 2024
Signed-off-by: Rui Chen <rui@chenrui.dev>

titan-server: update eol

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 13, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 6e06bb5 Sep 13, 2024
17 checks passed
@chenrui333 chenrui333 deleted the titan-server-deprecate branch September 13, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled java Java use is a significant feature of the PR or issue sequoia-bottling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants