Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli: update 2.17.53 bottle. #191092

Closed
wants to merge 1 commit into from
Closed

awscli: update 2.17.53 bottle. #191092

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This was missed in #191025.

Fixes #191091.

This was missed in #191025.

Fixes #191091.
@carlocab carlocab added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 18, 2024
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Sep 18, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is going to work, unfortunately. Bottles published in https://github.com/Homebrew/homebrew-core/actions/runs/10913298876/job/30289556807 are for 2.17.52, but it's on 2.17.53 already. I think the problem is that there was an attempt to resolve a conflict after the bottles were published, but the new bottles didn't make it.

I dispatched https://github.com/Homebrew/homebrew-core/actions/runs/10923566210.

@carlocab carlocab closed this Sep 18, 2024
@carlocab carlocab deleted the awscli-bottles branch September 18, 2024 13:58
@ZhongRuoyu
Copy link
Member

I dispatched https://github.com/Homebrew/homebrew-core/actions/runs/10923566210.

Actually, decided to revbump instead considering the number of users affected (awscli is our 14th most popular formula): #191093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue
Projects
None yet
2 participants