Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtatsu 1.0.4 (new formula) #196866

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tux-mind
Copy link

@tux-mind tux-mind commented Nov 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@chenrui333 chenrui333 changed the title Hotfix/libimobiledevice head libtatsu 1.0.4 (new formula) Nov 6, 2024
Added libtatsu, a libimobiledevice-suite library to
interact with apple signing servers.
As libimobiledevice keeps developing without releasing,
new dependencies are added. This commit the libtatsu
dependency when building from HEAD.

Closes libimobiledevice/libimobiledevice#1217
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 7, 2024
@tux-mind
Copy link
Author

tux-mind commented Nov 7, 2024

Is it possible to remove the notable repository requirement from the Formulae audit?

* GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)

The libtatsu repo is from libimobiledevice organization, whose main repo has 1.3k forks, 251 watchers and 6.7k stars ⭐

Thank you in advance for your precious help!

@jpstotz
Copy link

jpstotz commented Nov 7, 2024

The libtatsu repo is from libimobiledevice organization, whose main repo has 1.3k forks, 251 watchers and 6.7k stars ⭐

IMHO this is a bug of homebrew as it does not consider dependencies. libtatsu is a mandatory requirement of libimobiledevice which has 6.7k stars and 1.3k forks. Thus if a popular project requires a dependency the popularity of the dependency should be the cumulated popularity of all projects that depend on it, not just the project itself.

@daeho-ro daeho-ro added the CI-skip-new-formulae Pass --skip-new to brew test-bot. label Nov 7, 2024
@daeho-ro daeho-ro mentioned this pull request Nov 7, 2024
6 tasks
@daeho-ro daeho-ro added CI-skip-new-formulae Pass --skip-new to brew test-bot. and removed CI-skip-new-formulae Pass --skip-new to brew test-bot. labels Nov 7, 2024
@nikias
Copy link

nikias commented Nov 7, 2024

I agree with @jpstotz, also being the maintainer of libimobiledevice (et al.) I feel like this should not prevent the merge of this PR (it is used for personalized developer disk image mounting starting with iOS 17+).
Besides, it is a dependency of idevicerestore too.

@tux-mind
Copy link
Author

tux-mind commented Nov 7, 2024

Thanks @daeho-ro for adding the CI label, all the checks pass!

@chenrui333 can you please review and approve this PR?

Thank you for your help 😊

@daeho-ro daeho-ro requested a review from a team November 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-new-formulae Pass --skip-new to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants