Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-cli 0.8.3 #77942

Closed
wants to merge 2 commits into from
Closed

signal-cli 0.8.3 #77942

wants to merge 2 commits into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented May 24, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Also try to build on ARM.

@Moisan Moisan added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label May 24, 2021
@BrewTestBot BrewTestBot added java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels May 24, 2021
@cho-m
Copy link
Member

cho-m commented May 24, 2021

Looks like rust version used by libzkgroup is too old for Apple ARM support:
https://github.com/signalapp/zkgroup/blob/v0.7.2/rust-toolchain

==> make libzkgroup
RUSTFLAGS='-C link-arg=-s' cargo build --release
info: syncing channel updates for '1.41.1-aarch64-apple-darwin'
info: latest update on 2020-02-27, rust version 1.41.1 (f3e1a954d 2020-02-24)
error: target 'aarch64-apple-darwin' not found in channel.  Perhaps check https://doc.rust-lang.org/nightly/rustc/platform-support.html for available targets
make: *** [libzkgroup] Error 1

I guess you can try overriding with newer rust, but not sure if any incompatibilities will show up.

@Moisan Moisan removed the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label May 25, 2021
@carlocab
Copy link
Member

We should probably file an issue with libsignal-client to see if they can/will eventually support building with the latest version of Rust.

@carlocab
Copy link
Member

Oh, wait, there's already an upstream issue: signalapp/libsignal#291

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants